[Java][FlexBuffers] Improve documentation for FlexBuffers in Java. #5506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
reviewed
Sep 3, 2019
9ae15a9 to
f01b3c8
Compare
Collaborator
|
There appear to be some compile errors in the CI, e.g. |
Also add a FlexBuffer constructor to simplify usage
f01b3c8 to
55d5e91
Compare
Contributor
Author
Yes, I reduced the visibility of class from package-private to private, which triggered the error. I reverted the change. Hopefully it will be back to normal |
Contributor
Author
|
Hello @aardappel. Do you want to see any more changes on this MR? |
Collaborator
|
No, sorry.. the remaining CI errors are unrelated. |
LuckyRu
pushed a commit
to LuckyRu/flatbuffers
that referenced
this pull request
Oct 2, 2020
…oogle#5506) Also add a FlexBuffer constructor to simplify usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more documentation for FlexBuffers in Java.
Additionally adds a new constructor to FlexBufferBuilder to specify buffer size.