Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Thanks, this is a fix, but I agree that for any T that is not a byte it should return Span<T> instead. Of course, the one issue is that it refers to little-endian bytes, though not sure if there is even an implementation of C# for a big endian machine? :)

Thanks, this is a fix, but I agree that for any T that is not a byte it should return Span<T> instead. Of course, the one issue is that it refers to little-endian bytes, though not sure if there is even an implementation of C# for a big endian machine? :)

I can update to return a Span. My original plan was to do something like this:
return bb.ToSpan(pos, len * ByteBuffer.SizeOf()); and use the template type to get the size but I didn't see a good way to get the appropriate size for enums so I went with the extra parameter.

For the endianness question, I guess I could just make it throw like is done in: __vector_as_array, or maybe have both versions?

Yes, the size argument is probably faster anyway.
Yes, throwing on big endian would be a good solution.

Nice!

(CI errors unrelated).