Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flac] Add FlexBuffers option for generating data #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aardappel merged 1 commit into from
Sep 26, 2019
Merged

[flac] Add FlexBuffers option for generating data #5519

aardappel merged 1 commit into from
Sep 26, 2019

Conversation

@paulovap
Copy link
Contributor

@paulovap paulovap commented Sep 17, 2019

Alongside --binary and --json, an additional switch (--flexbuffers) can be passed to convert data using FlexBuffers.

aardappel
aardappel reviewed Sep 19, 2019
View reviewed changes
Copy link
Collaborator

@aardappel aardappel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, that was definitely missing!

@aardappel aardappel mentioned this pull request Sep 19, 2019
Closed
aardappel
aardappel reviewed Sep 25, 2019
View reviewed changes
@paulovap
[flac] Add FlexBuffers option for generating data
3528763 
Alongside --binary and --json, an additional
switch (--flexbuffers) can be passed to convert
data using FlexBuffers
@aardappel
Copy link
Collaborator

aardappel commented Sep 26, 2019

Thanks!

@aardappel aardappel merged commit cfb4ecf into google:master Sep 26, 2019
@vglavnyy
Copy link
Contributor

vglavnyy commented Nov 2, 2019

@paulovap
Perhaps, this code has a typo.
A predicate !opts.use_flexbuffers at line 438 is always true.

flatbuffers/src/flatc.cpp

Lines 427 to 446 in 32254b7

if (opts.use_flexbuffers) {
if (opts.lang_to_generate == IDLOptions::kJson) {
parser->flex_root_ = flexbuffers::GetRoot(
reinterpret_cast<const uint8_t *>(contents.c_str()),
contents.size());
} else {
parser->flex_builder_.Clear();
ParseFile(*parser.get(), filename, contents, include_directories);
}
} else {
ParseFile(*parser.get(), filename, contents, include_directories);
if (!opts.use_flexbuffers && !is_schema &&
!parser->builder_.GetSize()) {
// If a file doesn't end in .fbs, it must be json/binary. Ensure we
// didn't just parse a schema with a different extension.
Error("input file is neither json nor a .fbs (schema) file: " +
filename,
true);
}
}

PVS-Studio
V560 [CWE-571] A part of conditional expression is always true: !opts.use_flexbuffers. flatc.cpp 438

Could you fix it?

@paulovap
Copy link
Contributor Author

paulovap commented Nov 2, 2019

PVS-Studio
V560 [CWE-571] A part of conditional expression is always true: !opts.use_flexbuffers. flatc.cpp 438

Sure.
#5604

@vglavnyy
Copy link
Contributor

vglavnyy commented Nov 2, 2019

Thanks

LuckyRu pushed a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
@paulovap @LuckyRu
[flac] Add FlexBuffers option for generating data (google#5519)
fdd325f 
Alongside --binary and --json, an additional
switch (--flexbuffers) can be passed to convert
data using FlexBuffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aardappel aardappel aardappel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulovap @aardappel @vglavnyy