Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hkmix
Copy link
Contributor

@hkmix hkmix commented Sep 30, 2019

Changes the use of LookupStruct to LookupCreateStruct in
ParseField to also detect when collisions happen in namespaces.

Solution as given by @aardappel. Fixes #5540.

Changes the use of `LookupStruct` to `LookupCreateStruct` in
`ParseField` to also detect when collisions happen in namespaces.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hkmix
Copy link
Contributor Author

hkmix commented Sep 30, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@aardappel
Copy link
Collaborator

Thanks, I presume that fixes your issue :)

@aardappel aardappel merged commit 69d3fec into google:master Sep 30, 2019
@hkmix
Copy link
Contributor Author

hkmix commented Sep 30, 2019

It does, thank you :)

LuckyRu pushed a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
…oogle#5545)

Changes the use of `LookupStruct` to `LookupCreateStruct` in
`ParseField` to also detect when collisions happen in namespaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespaces allow field/struct name collisions

3 participants