Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[C#] Fix union verifier #8593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aardappel merged 4 commits into from
Aug 28, 2025
Merged

[C#] Fix union verifier #8593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d235f31
[C#] Add test verifying unions
TorsteinTenstadNorsonic May 5, 2025
31b936b
[C#] Fix verifying unions
TorsteinTenstadNorsonic May 5, 2025
8883a3b
Merge branch 'master' into fix-csharp-union-verifier
bjornharrtell Aug 24, 2025
9294fab
Merge branch 'master' into fix-csharp-union-verifier
aardappel Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions net/FlatBuffers/FlatBufferVerify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,10 +684,10 @@ public bool VerifyUnion(uint tablePos, short typeIdVOffset, short valueVOffset,
{
return false;
}
// Check union data
offset = GetVOffset(tablePos, valueVOffset);
// Take type id
var typeId = verifier_buffer.Get(Convert.ToInt32(offset));
// Check union data
offset = GetVOffset(tablePos, valueVOffset);
if (offset == 0)
{
// When value data is not present, allow union verification function to deal with illegal offset
Expand Down
30 changes: 30 additions & 0 deletions tests/FlatBuffers.Test/FlatBuffersExampleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,5 +1194,35 @@ public void SortKey_WithDefaultedValue_IsFindable() {
Assert.AreEqual(monster.ScalarKeySortedTablesByKey(i).Value.Count, i);
}
}

[FlatBuffersTestMethod]
public void TestVerifyingUnions()
{
var fbb = new FlatBufferBuilder(1);
var name_inner = fbb.CreateString("inner");
var name_outer = fbb.CreateString("outer");
Monster.StartMonster(fbb);
Monster.AddName(fbb, name_inner);
var monster_inner = Monster.EndMonster(fbb);
Monster.StartMonster(fbb);
Monster.AddName(fbb, name_outer);
Monster.AddTest(fbb, monster_inner.Value);
Monster.AddTestType(fbb, Any.Monster);
var monster_outer = Monster.EndMonster(fbb);
fbb.Finish(monster_outer.Value);
var bytes = fbb.SizedByteArray();
var bytes_to_corrupt_inner_name = fbb.SizedByteArray();
var bytes_to_corrupt_outer_name = fbb.SizedByteArray();

bytes_to_corrupt_inner_name[bytes.Length - name_inner.Value] = 0xFF;
bytes_to_corrupt_outer_name[bytes.Length - name_outer.Value] = 0xFF;
var valid = Monster.VerifyMonster(new ByteBuffer(bytes));
var valid_after_inner_corrupt = Monster.VerifyMonster(new ByteBuffer(bytes_to_corrupt_inner_name));
var valid_after_outer_corrupt = Monster.VerifyMonster(new ByteBuffer(bytes_to_corrupt_outer_name));

Assert.IsTrue(valid);
Assert.IsFalse(valid_after_inner_corrupt);
Assert.IsFalse(valid_after_outer_corrupt);
}
}
}
Loading