Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Python] Avoid double flatbuffers include in pyi files #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aardappel merged 1 commit into from
Jul 17, 2025
+1 −11
Merged

[Python] Avoid double flatbuffers include in pyi files #8626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/idl_gen_python.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ class PythonStubGenerator {
std::map<std::string, std::set<std::string>> names_by_module;
for (const Import &import : imports.imports) {
if (import.IsLocal()) continue; // skip all local imports
if (import.module == "flatbuffers" && import.name == "") continue; // skip double include hardcoded flatbuffers
if (import.name == "") {
modules.insert(import.module);
} else {
Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/ArrayStruct.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.NestedStruct import NestedStruct, NestedStructT
from MyGame.Example.TestEnum import TestEnum
Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/ArrayTable.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.ArrayStruct import ArrayStruct, ArrayStructT

Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedStruct.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.TestEnum import TestEnum

Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedUnion/Any.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.NestedUnion.TestSimpleTableWithEnum import TestSimpleTableWithEnum
from MyGame.Example.NestedUnion.Vec3 import Vec3
Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedUnion/Color.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from typing import cast

Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedUnion/NestedUnionTest.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.NestedUnion.Any import Any
from MyGame.Example.NestedUnion.TestSimpleTableWithEnum import TestSimpleTableWithEnumT
Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedUnion/Test.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing

uoffset: typing.TypeAlias = flatbuffers.number_types.UOffsetTFlags.py_type
Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedUnion/TestSimpleTableWithEnum.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.NestedUnion.Color import Color

Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/NestedUnion/Vec3.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from MyGame.Example.NestedUnion.Color import Color
from MyGame.Example.NestedUnion.Test import Test, TestT
Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/Example/TestEnum.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing
from typing import cast

Expand Down
1 change: 0 additions & 1 deletion tests/MyGame/MonsterExtra.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from __future__ import annotations
import flatbuffers
import numpy as np

import flatbuffers
import typing

uoffset: typing.TypeAlias = flatbuffers.number_types.UOffsetTFlags.py_type
Expand Down
Loading