runsc/cgroup: set swap for precreated cgroups#13276
Merged
copybara-service[bot] merged 1 commit intoJun 11, 2026
Merged
Conversation
Contributor
Author
|
This is ready for review. The patch applies swap settings for precreated cgroup v2 paths and adds coverage in cgroup_v2_test. The visible checks are green. |
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 11, 2026
## Summary - honor OCI `LinuxResources.Memory.Swap` for cgroup v2 paths that were pre-created by the caller - keep the existing pre-created-cgroup ownership behavior for other resource knobs, so runsc does not overwrite pod CPU or memory limits it does not own - add a regression test that verifies `memory.swap.max` is updated while `memory.max` stays untouched Fixes #13267 ## Testing - `git diff --check` - `bazel test //runsc/cgroup:cgroup_test` (fails before running tests on this macOS host because `/usr/bin/x86_64-linux-gnu-gcc` is not installed for the `//vdso:vdso` genrule) FUTURE_COPYBARA_INTEGRATE_REVIEW=#13276 from Haihan-Jiang:codex/gvisor-cgroup-swap b393e6f PiperOrigin-RevId: 930735286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinuxResources.Memory.Swapfor cgroup v2 paths that were pre-created by the callermemory.swap.maxis updated whilememory.maxstays untouchedFixes #13267
Testing
git diff --checkbazel test //runsc/cgroup:cgroup_test(fails before running tests on this macOS host because/usr/bin/x86_64-linux-gnu-gccis not installed for the//vdso:vdsogenrule)