Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include <chrono> for system_clock #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NEIL-smtg wants to merge 1 commit into from
Closed

Include <chrono> for system_clock #25

NEIL-smtg wants to merge 1 commit into from

Conversation

@NEIL-smtg
Copy link

@NEIL-smtg NEIL-smtg commented Nov 26, 2024 •
edited
Loading

I work on Microsoft Visual C++ testing, where we regularly build popular open-source projects, including yours, with development builds of our compiler and libraries to detect and prevent shipping regressions that would affect you. This also allows us to provide advance notice of breaking changes, which is the case here.

Recently this commit microsoft/STL#5105 is revealing an issue in nysnc.

Compiler error with this STL change:

./external/nsync//platform/c++11\platform.h(67): error C2039: 'system_clock': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
./external/nsync//platform/c++11\platform.h(67): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
./external/nsync//platform/c++11\platform.h(67): error C2133: 'epoch': unknown size
./external/nsync//platform/c++11\platform.h(67): error C2512: 'std::chrono::time_point': no appropriate default constructor available
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\__msvc_chrono.hpp(200): note: see declaration of 'std::chrono::time_point'
./external/nsync//platform/c++11\platform.h(69): error C2676: binary '+': 'std::chrono::time_point' does not define this operator or a conversion to a type acceptable to the predefined operator

Affected code:

nsync/platform/c++11/platform.h

Lines 67 to 71 in c620517

std::chrono::system_clock::time_point epoch;
result = (*cv)->wait_until (mu_mu,
epoch + std::chrono::nanoseconds (
abstimeout->tv_nsec +
1000 * 1000 * 1000 * (int64_t) abstimeout->tv_sec));

This was assuming that including makes the chrono::system_clock type available, which is not guaranteed by the Standard. You need to explicitly include the chrono header in this file, and the error will be resolved.

@google-cla
Copy link

google-cla bot commented Nov 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NEIL-smtg NEIL-smtg mentioned this pull request Nov 26, 2024
Closed
@StephanTLavavej
Copy link

StephanTLavavej commented Nov 26, 2024

After signing the CLA, the addition of <chrono> should be grouped with <mutex> and <condition_variable>, to avoid interfering with the comment about C compatibility headers.

@LilyWangLL LilyWangLL mentioned this pull request Nov 28, 2024
Merged
7 tasks
@m3bm3b
Copy link
Collaborator

m3bm3b commented Apr 9, 2025

Sorry for the delay.

The change looks ok, but the new include directive is right under a comment that doesn't apply to it.
Could you move it to just after the line that includes "condition_variable"?
That way, the C++-specific include files are together.

@LevitatingBusinessMan LevitatingBusinessMan mentioned this pull request Sep 8, 2025
Merged
@m3bm3b m3bm3b closed this in #26 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NEIL-smtg @StephanTLavavej @m3bm3b