-
Notifications
You must be signed in to change notification settings - Fork 517
Python Docstring relocation #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Oh, I really wish I understood what was going on here! |
I didn't have a signed CLA, so I followed the google bot instructions, which include that command, with the exclamation (I know, seems like I'm arguing with it, hah)
|
|
||
|
||
def encode(latitude, longitude, codeLength=PAIR_CODE_LENGTH_): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Looks like an extra newline snuck in here.
valid full code, it is returned with proper capitalization but otherwise | ||
unchanged. | ||
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove extra newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! It looks like at some point autoformatting added padding between the out-of-place docstrings and function defs, so now there are four empty lines. Mind removing the padding too so that there will be two empty lines separating each top level function def?
This PR removes newlines from the file, so that your PR to google/open-location-code can be accepted according to: google#418
See Issue 417