Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bheliker
Copy link
Contributor

See Issue 417

@google-cla
Copy link

google-cla bot commented Oct 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 16, 2020
@bheliker
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 16, 2020
@RiverMersey
Copy link

Oh, I really wish I understood what was going on here!
All that I do know is that @bheliker seems to be arguing with a software robot!

@bheliker
Copy link
Contributor Author

I didn't have a signed CLA, so I followed the google bot instructions, which include that command, with the exclamation (I know, seems like I'm arguing with it, hah)

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.



def encode(latitude, longitude, codeLength=PAIR_CODE_LENGTH_):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Looks like an extra newline snuck in here.

valid full code, it is returned with proper capitalization but otherwise
unchanged.
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra newline.

Copy link
Contributor

@bilst bilst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It looks like at some point autoformatting added padding between the out-of-place docstrings and function defs, so now there are four empty lines. Mind removing the padding too so that there will be two empty lines separating each top level function def?

bocops added a commit to bocops/open-location-code that referenced this pull request Apr 22, 2021
This PR removes newlines from the file, so that your PR to google/open-location-code can be accepted according to: google#418
@bocops bocops mentioned this pull request Apr 30, 2021
@bilst bilst closed this in #455 May 4, 2021
bilst added a commit that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants