feat: guess the indentation for <dependency> element when writing XML #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
+ Coverage 65.05% 65.23% +0.17%
==========================================
Files 165 165
Lines 15837 15856 +19
==========================================
+ Hits 10303 10343 +40
+ Misses 4867 4848 -19
+ Partials 667 665 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaelkedar
reviewed
May 1, 2025
michaelkedar
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the common indentation when writing
<dependency>elements. This PR improves the writer behaviour by getting the indentation of the first<dependency>element in dependencies so the newly added XMLs are more readable.