fix: include actual error if Maven registry response body cannot be read #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
approved these changes
Jun 3, 2025
another-rex
approved these changes
Jun 3, 2025
Collaborator
another-rex
left a comment
There was a problem hiding this comment.
Good catch! I think we should just swap the branches though to be more consistent.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
=======================================
Coverage 65.66% 65.67%
=======================================
Files 166 166
Lines 16063 16064 +1
=======================================
+ Hits 10548 10550 +2
+ Misses 4849 4848 -1
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0765795 to
eba4115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're creating a local variable
errwhich shadows the outer variable, so while we do still correctly go off the happy path in this case, the error we return does not include the underlying error message since we use the outererrvariable which at this point will holdnil.This was found by the
nilnesserrlinter which is a new linter included in v2 that "combinesnilnessandnilerr", and that I've enabled as part of this