Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: surface jar reachability results #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hogo6002 merged 16 commits into from
Aug 13, 2025
Merged

feat: surface jar reachability results #2113

hogo6002 merged 16 commits into from
Aug 13, 2025

Conversation

@hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Jul 25, 2025 •
edited
Loading

  • enables call analysis on all scanning types
  • adds "Jar" call analysis option
  • enables Java reachability enricher if call analysis config includes JAR
  • annotates all vulnerabilities from unreachable packages as uncalled
  • adds unit tests for Java archive scanning with call analysis enabled

@hogo6002 hogo6002 marked this pull request as ready for review July 29, 2025 03:59
@hogo6002 hogo6002 requested a review from another-rex July 29, 2025 03:59
@hogo6002
Copy link
Contributor Author

hogo6002 commented Jul 29, 2025

PR is ready for code review. The unit tests will be fixed after google/osv-scalibr#946 merges in.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.16%. Comparing base (a8c97f3) to head (eceb53f).

Files with missing lines Patch % Lines
pkg/osvscanner/osvscanner.go 30.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   67.52%   67.16%   -0.37%     
==========================================
  Files         169      169              
  Lines       16248    16326      +78     
==========================================
- Hits        10972    10965       -7     
- Misses       4601     4678      +77     
- Partials      675      683       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

another-rex
another-rex reviewed Jul 29, 2025
View reviewed changes
G-Rath
G-Rath reviewed Jul 31, 2025
View reviewed changes
G-Rath
G-Rath reviewed Jul 31, 2025
View reviewed changes
@another-rex
Copy link
Collaborator

another-rex commented Aug 12, 2025

Is this still blocked on windows tests after you made the change in osv-scalibr?

@hogo6002
Copy link
Contributor Author

hogo6002 commented Aug 12, 2025

Is this still blocked on windows tests after you made the change in osv-scalibr?

It's pending on osv-scalibr version update in osv-scanner

@hogo6002 hogo6002 merged commit 6f95142 into google:main Aug 13, 2025
13 of 15 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@G-Rath G-Rath G-Rath left review comments

@another-rex another-rex another-rex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hogo6002 @codecov-commenter @another-rex @G-Rath