fix: improve logic for --all-packages flag
#2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unscannable packages are still filtered for vuln and license matching, but they will be re-added to the final display result if `--all-packages`flag is passed in Fixes google#2157
Made clear the order of precedence between `--all-packages` flag and `PackageOverrides` actions in config file
Collaborator
|
Test error seems to be from a snapshot update, just run tests with UPDATE_SNAPS=true and it should be fixed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
- Coverage 67.95% 67.91% -0.05%
==========================================
Files 172 172
Lines 12821 12836 +15
==========================================
+ Hits 8712 8717 +5
- Misses 3437 3446 +9
- Partials 672 673 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logic so that unscannable packages are still filtered for vulnerabilities and license matching, but they will be re-added to the final JSON result if the
--all-packagesflag is passed in.Also updated docs to clarify the order of precedence between
--all-packagesflag andPackageOverridesactions in the config file.Fixes #2157