Update to Gradle 8.13 and replace usage of deprecated Gradle exception type #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
May 15, 2025
| } | ||
| } | ||
| } catch (AmbiguousVariantSelectionException exception) { | ||
| } catch (ArtifactSelectionException exception) { |
There was a problem hiding this comment.
@tresat on older versions of Gradle running this branch may throw an exception when JVM tries to find the catch block for AmbiguousVariantSelectionException when it is thrown, because this new ArtifactSelectionException might not be available in those old versions of Gradle. (I have no proof, just something that came to mind when seeing this change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are aiming to remove this type in an upcoming Gradle release. This change updates the version of Gradle used to build the OSS licenses project to the most recent release and replaces the usages of the deprecated type with its replacement. This plugin should be unaffected.