Server example#17
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
brianquinlan
left a comment
There was a problem hiding this comment.
Thanks very much for your contribution!
If you make the fixes that I suggested then I'd be happy to merge.
But this would be even better if:
- you created a requirements.txt (https://pip.pypa.io/en/stable/user_guide/#requirements-files)
- you created a README.md in this directory explaining how to run the server and access the resulting image.
brianquinlan
left a comment
There was a problem hiding this comment.
Thank you very much, feel free to merge!
If you wanted, you could file an issue to add tests to this example and then write them ;-)
Add server example that serves badges