Conversation
There are small typos in: - fire/console/console_attr.py - fire/custom_descriptions.py Fixes: - Should read `support` rather than `suport`. - Should read `pertinent` rather than `pertinant`. - Should read `environment` rather than `envrionment`.
Collaborator
|
Thanks for fixing these typos! The console/ directory is actually a third_party dep and we don't generally update that code manually (since the updates just get clobbered when we pull in from upstream.) I'll merge your PR as is though (and if/when we next pull in a console update, the typos might return!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are small typos in:
Fixes:
supportrather thansuport.pertinentrather thanpertinant.environmentrather thanenvrionment.Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md