Codestin Search App

greenmoon55 · 2017-10-13T02:12:34Z

Fixes #84

dbieber

This is great, I wish I'd noticed your pull request sooner. 2 comments inline.

dbieber · 2017-11-21T21:47:54Z

fire/core.py

-          arg_consumed = True
+        else:
+          unconsumed_named_args.append(argument)
+        arg_consumed = True


We can remove arg_consumed altogether (here and at 698), and replace the if at 739 with an else.

dbieber · 2017-11-21T21:51:17Z

fire/core.py

@@ -684,6 +685,7 @@ def _ParseKeywordArgs(args, fn_args, fn_keywords):
    remaining_args: A list of the unused arguments from the original args.


Please update the Returns: section of the docstring.

Also how about "remaining_kwargs" instead of unconsumed_named_args for consistency with the existing terminology?

greenmoon55 · 2017-11-25T20:58:10Z

Thanks! I'll look into it.

dbieber · 2017-11-27T19:36:17Z

Heads up that some of the tests are failing. You can see the details here (https://travis-ci.org/google/python-fire/jobs/287352133) or by clicking "Details" next to the continuous-integration line after "Some checks were not successfull".

It looks like the majority of the failures are using the components tc.Kwargs or tc.MixedDefaults.

A good first place to investigate might be why this assert is failing [1] [2]:

python-fire/fire/fire_test.py

Lines 344 to 346 in b5053ba

    
           self.assertEqual( 
        
               fire.Fire(tc.MixedDefaults, 
        
                         command=['identity', '--alpha', '--beta', '10']), (True, 10))

Here's the definition of MixedDefaults:

python-fire/fire/test_components.py

Lines 74 to 83 in a0791c9

    
           class MixedDefaults(object): 
        
             def ten(self): 
        
               return 10 
        
             def sum(self, alpha=0, beta=0): 
        
               return alpha + 2 * beta 
        
             def identity(self, alpha, beta='0'): 
        
               return alpha, beta

For what it's worth, these components are also used in many of the failing tests:

python-fire/fire/test_components.py

Lines 56 to 62 in a0791c9

    
           class WithDefaults(object): 
        
             def double(self, count=0): 
        
               return 2 * count 
        
             def triple(self, count=0): 
        
               return 3 * count

python-fire/fire/test_components.py

Lines 175 to 184 in a0791c9

    
           class Kwargs(object): 
        
             def props(self, **kwargs): 
        
               return kwargs 
        
             def upper(self, **kwargs): 
        
               return ' '.join(sorted(kwargs.keys())).upper() 
        
             def run(self, positional, named=None, **kwargs): 
        
               return (positional, named, kwargs)

greenmoon55 · 2017-12-03T18:23:41Z

fire/core.py

+  remaining_kwargs = []
+  remaining_args = []
+
+  if not args:


I add a return statement here because pylint complains about "Too many nested blocks (6/5)". Not sure if I should do it this way.

Seems ok to me.

Another possibility would be moving some of the inner blocks into their own functions, but I don't see a super clean way to do that.

greenmoon55 · 2017-12-03T18:26:07Z

@dbieber Thanks for the tip! I forgot to save the value corresponding to the keyword.

dbieber

This looks good!

dbieber · 2017-12-04T18:45:48Z

fire/core.py

    """Parses the list of `args` into (varargs, kwargs), remaining_args."""
-    kwargs, remaining_args = _ParseKeywordArgs(args, all_args, fn_spec.varkw)
+    kwargs, remaining_kwargs, remaining_args = \
+        _ParseKeywordArgs(args, all_args, fn_spec.varkw)


nit: for consistency w/ codebase, let's do:

kwargs, remaining_kwargs, remaining_args = _ParseKeywordArgs( args, all_args, fn_spec.varkw)

dbieber · 2017-12-04T18:49:19Z

fire/core.py

+  remaining_kwargs = []
+  remaining_args = []
+
+  if not args:


Seems ok to me.

Another possibility would be moving some of the inner blocks into their own functions, but I don't see a super clean way to do that.

dbieber · 2017-12-04T18:50:37Z

fire/fire_test.py

+        fire.Fire(
+            tc.MixedDefaults,
+            command=['identity', '--alpha', 'True', '"--test"']),
+        (True, '--test'))


dbieber · 2017-12-04T20:11:58Z

fire/fire_test.py

@@ -368,10 +368,15 @@ def testBoolParsingLessExpectedCases(self):
        fire.Fire(tc.MixedDefaults,
                  command=['identity', 'True', '10']), (True, 10))



Another thing that may be worthwhile to test is the behavior in the presence of separators / chained function calls.

For example, with these components:

def example_component(arg1, kwarg2='default2'): def inner_component(kwarg3='default3'): return kwarg3 return inner_component

def example_component(arg1, *varargs): def inner_component(kwarg3='default3'): return kwarg3 return inner_component

What is the behavior of these calls?

fire.Fire(example_component, command=['value1', '-', '--kwarg3', 'value3']) == 'value3'
fire.Fire(example_component, command=['value1', '--kwarg3', 'value3'])

dbieber · 2017-12-04T22:00:40Z

I'm going to go ahead and squash + merge. If you're up for adding those tests and/or making the nit fix, go ahead and do so in a follow up PR.

Do not treat arguments that start with '--' as string.

6c2c1fc

dbieber reviewed Nov 21, 2017

View reviewed changes

greenmoon55 added 2 commits December 3, 2017 13:02

Fixes kwarg value bug and modify test case for arg starting with '--'

5c5d238

Fix pylint errors

a572ad7

greenmoon55 commented Dec 3, 2017

View reviewed changes

dbieber reviewed Dec 4, 2017

View reviewed changes

dbieber merged commit fa57593 into google:master Dec 4, 2017

jtratner mentioned this pull request Jan 3, 2018

Confusing behavior on typos when keyword args are reinterpreted as positional arguments #109

Closed

dbieber mentioned this pull request Jan 17, 2018

Cut a new release for python-fire #112

Closed

greenmoon55 deleted the fix-argument branch June 15, 2018 21:26

		@@ -684,6 +685,7 @@ def _ParseKeywordArgs(args, fn_args, fn_keywords):
		remaining_args: A list of the unused arguments from the original args.

		@@ -368,10 +368,15 @@ def testBoolParsingLessExpectedCases(self):
		fire.Fire(tc.MixedDefaults,
		command=['identity', 'True', '10']), (True, 10))

Conversation

greenmoon55 commented Oct 13, 2017

Uh oh!

dbieber left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greenmoon55 commented Nov 25, 2017

Uh oh!

dbieber commented Nov 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greenmoon55 commented Dec 3, 2017

Uh oh!

dbieber left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dbieber commented Dec 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants