Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

timothyjward
Copy link
Contributor

In order to use this library in an OSGi framework it needs to include OSGi metadata. Rather than users having to repackage the code, it would be easier if the library jar already contained OSGi bundle metadata.

@google-cla
Copy link

google-cla bot commented Jul 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Aug 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@timothyjward
Copy link
Contributor Author

Rebased to fix the merge issue

@eengle
Copy link
Collaborator

eengle commented Aug 12, 2021 via email

@timothyjward
Copy link
Contributor Author

@googlebot I signed it!

@timothyjward
Copy link
Contributor Author

Can you address the CLA issue?

Is there anything further that you need me to do?

Copy link
Collaborator

@eengle eengle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the jar plugin as well. Can you update the description?

@eengle
Copy link
Collaborator

eengle commented Sep 10, 2021

CLAs look good to me now. Sorry that took awhile.

This commit adds two plugins to the pom.xml

 * `bnd-maven-plugin` to generate an OSGi manifest by scanning the bytecode for metadata and dependency information.
 * `maven-jar-plugin` to include the manifest generated by the `bnd-maven-plugin` in the output jar file

Further configuration of the `bnd-maven-plugin` occurs in bnd.bnd, which contains instructions as to how the manifest should be generated

Signed-off-by: Tim Ward <[email protected]>
@timothyjward
Copy link
Contributor Author

Thanks for adding the jar plugin as well. Can you update the description?

I've added a more descriptive commit message

@eengle eengle merged commit 9cc0dd9 into google:master Sep 16, 2021
@eengle
Copy link
Collaborator

eengle commented Sep 16, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants