-
Notifications
You must be signed in to change notification settings - Fork 237
Add OSGi metadata to the S2 geometry library #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
75c1fb9
to
7199c09
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Rebased to fix the merge issue |
Can you address the CLA issue?
…On Wed, Aug 11, 2021 at 8:43 AM Tim Ward ***@***.***> wrote:
Rebased to fix the merge issue
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4DAANALCSGNRZRDVR4PM3T4KLBTANCNFSM5BD3H4KQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
@googlebot I signed it! |
Is there anything further that you need me to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the jar plugin as well. Can you update the description?
CLAs look good to me now. Sorry that took awhile. |
This commit adds two plugins to the pom.xml * `bnd-maven-plugin` to generate an OSGi manifest by scanning the bytecode for metadata and dependency information. * `maven-jar-plugin` to include the manifest generated by the `bnd-maven-plugin` in the output jar file Further configuration of the `bnd-maven-plugin` occurs in bnd.bnd, which contains instructions as to how the manifest should be generated Signed-off-by: Tim Ward <[email protected]>
7199c09
to
9114c7a
Compare
I've added a more descriptive commit message |
Thanks! |
In order to use this library in an OSGi framework it needs to include OSGi metadata. Rather than users having to repackage the code, it would be easier if the library jar already contained OSGi bundle metadata.