This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Added method getViewIntent, which is missing in the code sample#16
Open
Shanannigans wants to merge 1 commit intogoogle:masterfrom
Open
Added method getViewIntent, which is missing in the code sample#16Shanannigans wants to merge 1 commit intogoogle:masterfrom
Shanannigans wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it. |
| return intent; | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
nit: Unnecessary new line
Contributor
|
Hi @Shanannigans. This sample is being used for a couple different codelabs. |
Author
|
Hi, of course, this is the codelab that I meant @zayna-shahzad : http://search-codelabs.appspot.com/codelabs/voice-search |
sdoooh
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Google codelabs example, this method is missing and it is nowhere mentioned that the user should add it.