Fix: List Index out out range with empty parts [] #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while question was blocked by api, the parts is an empty list [], so the exp: if len(parts) > 1 or "text" not in parts[0]: will raise list index out of range, but not ValueError
MarkDaoust
reviewed
Dec 19, 2023
MarkDaoust
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while question was blocked by api, the parts is an empty list [], so the exp:
if len(parts) > 1 or "text" not in parts[0]:
will raise list index out of range, but not ValueError
Description of the change
check parts before parts[0]
Motivation
Type of change
Choose one: (Bug fix | Feature request | Documentation | Other)
Bug fix
Checklist
git pull --rebase upstream main).