Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix build docs. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2023
Merged

Fix build docs. #150

merged 2 commits into from
Dec 23, 2023

Conversation

MarkDaoust
Copy link
Collaborator

GRPC has a circular import that's skipped by the typing flag. Move imports to make the build pass.

in grpc/_typing.py:

if TYPE_CHECKING:
    from grpc import ServicerContext
    from grpc._server import _RPCState

@MarkDaoust MarkDaoust requested a review from a team as a code owner December 21, 2023 22:52
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 21, 2023
@shilpakancharla shilpakancharla merged commit 7698c69 into main Dec 23, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 23, 2023
@MarkDaoust MarkDaoust deleted the MarkDaoust-patch-9 branch October 3, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilpakancharla shilpakancharla shilpakancharla approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkDaoust @shilpakancharla