Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

MarkDaoust
Copy link
Collaborator

Description of the change

Enable testing with python 3.12

Motivation

3.12 is the latest version of python and is now supported by the underlying GAPIC and auth libraries.

https://devguide.python.org/versions/

Type of change

Feature request

Checklist

  • [x ] I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@MarkDaoust MarkDaoust requested a review from a team as a code owner January 10, 2024 21:42
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jan 10, 2024
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Will you publish on PyPI too?

@markmcd markmcd merged commit 842550f into google-gemini:main Jan 11, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 11, 2024
@MarkDaoust
Copy link
Collaborator Author

PyPI too?

I was planning to make a new release when Shilpa gets the AQA and retriever submitted. But it wouldn't hurt to do another before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants