Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated naming regex, made naming process simpler. #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 5, 2024
Merged

Updated naming regex, made naming process simpler. #191

merged 22 commits into from
Feb 5, 2024

Conversation

shilpakancharla
Copy link
Collaborator

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@shilpakancharla shilpakancharla requested a review from a team as a code owner February 1, 2024 00:10
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Feb 1, 2024
markmcd
markmcd reviewed Feb 1, 2024
View reviewed changes
@MarkDaoust MarkDaoust mentioned this pull request Feb 1, 2024
Closed
MarkDaoust
MarkDaoust requested changes Feb 1, 2024
View reviewed changes
MarkDaoust
MarkDaoust reviewed Feb 5, 2024
View reviewed changes
MarkDaoust
MarkDaoust previously approved these changes Feb 5, 2024
View reviewed changes
@MarkDaoust MarkDaoust merged commit b3fa336 into google-gemini:main Feb 5, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd left review comments

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilpakancharla @markmcd @MarkDaoust