Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix response_schema with TypedDict #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix response_schema with TypedDict #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion google/generativeai/types/content_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,9 @@ def _build_schema(fname, fields_dict):
for name, value in defs.items():
unpack_defs(value, defs)
unpack_defs(parameters, defs)

required_fields = []
if (fname == "dummy" and fields_dict["dummy"]):
required_fields = parameters['properties'][fname].get('required',None)
# 5. Nullable fields:
# * https://github.com/pydantic/pydantic/issues/1270
# * https://stackoverflow.com/a/58841311
Expand All @@ -435,6 +437,8 @@ def _build_schema(fname, fields_dict):
# * https://github.com/pydantic/pydantic/issues/1051
# * http://cl/586221780
strip_titles(parameters)
if required_fields:
parameters['properties']['dummy']['required']= required_fields
return parameters


Expand Down
1 change: 1 addition & 0 deletions tests/test_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,7 @@ def test_repr_for_generate_content_response_from_iterator(self):
),
),
),
required=list(("name", "favorite_color", "birthday"))
),
],
)
Expand Down
Loading