Add count_text_tokens, and expose operations. #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d8ccdb to
16c10b9
Compare
markmcd
previously approved these changes
Oct 5, 2023
|
|
||
| def get_base_model_name( | ||
| model: model_types.AnyModelNameOptions, client: glm.ModelServiceClient | None = None | ||
| ): |
873d6af to
c2af4d5
Compare
|
Merge #78 first. |
c4f087c to
d4fa2e2
Compare
markmcd
previously approved these changes
Oct 10, 2023
tests/test_text.py
Outdated
|
|
||
| response = text_service.count_text_tokens(model, "Tell me a story about a magic backpack.") | ||
| self.assertEqual({"token_count": 7}, response) | ||
| if len(self.observed_requests) > 1: |
There was a problem hiding this comment.
Can we make the guard condition here something that makes it clear why it's optional? e.g. if make_model_name(model).startswith("tunedModel/"): ... or an extra param like should_look_up_model=bool
9b27bd4 to
106b974
Compare
markmcd
approved these changes
Oct 11, 2023
markmcd
pushed a commit
to markmcd/generative-ai-python
that referenced
this pull request
Oct 30, 2023
* Add count_text_tokens, and expose operations. * Format and fix pytype errors. * use get_base_model_name in create_tuned_model * Resolve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Motivation
These should have been in v1beta2.
Type of change
Feature
Checklist
git pull --rebase upstream main).