Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update dataset construction code to handle more input types. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2023
Merged

Update dataset construction code to handle more input types. #79

merged 6 commits into from
Oct 18, 2023

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Oct 6, 2023 •
edited
Loading

Description of the change

Let create_tuned_model accept column-oriented dictionaries, file paths, and URLs.

Motivation

Make it easy to pass more objects as datasets.

b/297597494

Type of change

Choose one: Feature request

@MarkDaoust MarkDaoust requested a review from a team as a code owner October 6, 2023 00:30
@MarkDaoust MarkDaoust marked this pull request as draft October 6, 2023 00:30
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 6, 2023
@MarkDaoust
Copy link
Collaborator Author

@xinyij-goo

@ymodak ymodak added component:python sdk Issue/PR related to Python SDK subcategory:python api labels Oct 9, 2023
@MarkDaoust MarkDaoust marked this pull request as ready for review October 11, 2023 00:18
markmcd
markmcd previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, and thanks!

(don't feel like you have to wait for me to re-review any minor changes either, I think GitHub will still let admins submit after the first approval)

@MarkDaoust MarkDaoust force-pushed the columns branch 2 times, most recently from 70f9070 to 536d370 Compare October 17, 2023 17:12
@MarkDaoust MarkDaoust changed the title Columns Update dataset construction code to handle more input types. Oct 17, 2023
@markmcd markmcd merged commit 2eb5e82 into google-gemini:main Oct 18, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 18, 2023
markmcd pushed a commit to markmcd/generative-ai-python that referenced this pull request Oct 30, 2023
@MarkDaoust @markmcd
Update dataset construction code to handle more input types. (google-…
f6e425a 
…gemini#79)

* Allow dicts and pd.DataFrames as tuning datasets

* fix type hints.

* Support csv and json files, csv URLs.

* docs

* add TODO

* Allow json-urls and streaming decoding of CSVs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDaoust @markmcd @ymodak