bug(/review): Fix agent not posting feedback in GitHub #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcf83d to
ad366fa
Compare
jerop
reviewed
Aug 7, 2025
Contributor
|
Can you rebase? |
ad366fa to
48e28fc
Compare
sethvargo
approved these changes
Aug 8, 2025
Contributor
|
@gemini-cli /review |
48e28fc to
d1dc939
Compare
d1dc939 to
16922fb
Compare
16922fb to
40df6a1
Compare
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Aug 8, 2025
## What's Changed * Broken links by @kulaone in #129 * chore: mention user to confirm who run by @Marukome0743 in #131 * bug(#109): Support triggering PR review with issue comment by @leehagoodjames in #138 * feat(setup): enable setup script to automatically set repository variables by @leehagoodjames in #140 * Add `echo` to core tools for automated issue triage by @jerop in #143 * chore: simply GitHub Actions permissions by @sethvargo in #144 * Simplify the workflow triggers by @jerop in #146 * bug(/review): Fix agent not posting feedback in GitHub by @leehagoodjames in #141 ## New Contributors * @kulaone made their first contribution in #129 **Full Changelog**: v0.1.6...v0.1.7
dan-ri
reviewed
Aug 8, 2025
| 2. Run: echo "${CHANGED_FILES}" to get the list of changed files | ||
| 3. Run: echo "${PR_NUMBER}" to get the PR number | ||
| 4. Run: echo "${ADDITIONAL_INSTRUCTIONS}" to see any specific review | ||
| 1. Run: echo $"{REPOSITORY}" to get the github repository in <OWNER>/<REPO> format |
There was a problem hiding this comment.
This is a bug.
Suggested change
| 1. Run: echo $"{REPOSITORY}" to get the github repository in <OWNER>/<REPO> format | |
| 1. Run: echo "${REPOSITORY}" to get the github repository in <OWNER>/<REPO> format |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the prompt to constrain the agent on how the review must be submitted to GitHub. This aims to improve what is seen in #134 where "more than 50% of the time PR review fails due to tool problems posting the review."
Since this is occurring intermittently - this is a probabilistic issue, not a permissions issue, which is why the prompt is being changed.
Primary changes:
ownerto make tool calls. The change instructs the agent to list the repository owner.ownerand made tool calls with this, our logs show that these calls were successful (so the agent thought things were working), which is why workflow errors did not surface. I have filed a bug with GitHub MCP to ensure they are returning failures, and will ensure thatgemini-clilogs/telemetry is properly capturing and recording tool call failures.Fixes #134