Fix live streaming output whilst preserving stdout/stderr separation #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Hey @iclectic this is a good fix, thank you. However, we've gotten feedback that we shouldn't print output at all, since it's possible to trick the LLM into revealing information in the logs like secrets. |
leehagoodjames
pushed a commit
to leehagoodjames/run-gemini-cli
that referenced
this pull request
Aug 20, 2025
…hub-actions#207) This feels like a reasonable compromise between having no output at all. - Closes google-github-actions#203 (thanks @iclectic, your commit is in this PR) - Fixes google-github-actions#189 --------- Co-authored-by: iclectic <[email protected]> Co-authored-by: Ibim Braide <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #186, users wait until processes finish before seeing output. This uses tee with process substitution to stream live whilst maintaining separate stdout/stderr capture.
Testing confirms both streaming and separation work correctly.