fix(action): correct upload artifacts condition #368
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous condition `${{ inputs.upload_artifacts }}` would evaluate to true for any non-empty string, causing artifacts to be uploaded even when the input was false.
This change corrects the condition to `${{ inputs.upload_artifacts == true }}`, ensuring that artifacts are only uploaded when the `upload_artifacts` input is explicitly set to true.
Co-authored-by: [email protected]
Contributor
Author
|
this is a follow up to #361 - cc @joshualitt |
Contributor
Author
|
this supersedes #367 by @CallumHYoung |
bdmorgan
approved these changes
Oct 23, 2025
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Oct 23, 2025
## What's Changed * Move `gemini-invoke` to custom command. by @joshualitt in #348 * Move rest of prompts to custom commands. by @joshualitt in #350 * Normalize tool names in prompts. by @joshualitt in #351 * Fix interpolation syntax. by @joshualitt in #357 * Switch to local telemetry and upload manually to GCP by @joshualitt in #361 * fix: Adapt to GitHub MCP Tooling Consolidation by @cperez08 in #354 * refactor(ci): prioritize event triggers in dispatch workflow by @jerop in #366 * fix(action): correct upload artifacts condition by @jerop in #368 ## New Contributors * @joshualitt made their first contribution in #348 * @cperez08 made their first contribution in #354 **Full Changelog**: v0.1.13...v0.1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous condition
${{ inputs.upload_artifacts }}would evaluate to true for any non-empty string, causing artifacts to be uploaded even when the input was false.This change corrects the condition to
${{ inputs.upload_artifacts == true }}, ensuring that artifacts are only uploaded when theupload_artifactsinput is explicitly set to true.Co-authored-by: [email protected]