Add code samples for audience insights APIs #932
Merged
+234
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review the change for Audience Insights API code samples |
BenRKarl
requested changes
Apr 25, 2025
| request = client.get_type("GenerateAudienceCompositionInsightsRequest") | ||
| request.customer_id = customer_id | ||
|
|
||
| request.audience = client.get_type("InsightsAudience") |
There was a problem hiding this comment.
You don't need this line. You can set the request.audience fields, as you do later in the example, without this.
| customer_id, user_interest | ||
| ) | ||
| user_interests_info.user_interest_category = user_interest_category | ||
| attributes.user_interest = user_interests_info |
There was a problem hiding this comment.
Instead of this:
attributes = client.get_type("AudienceInsightsAttribute")
user_interests_info = client.get_type("UserInterestInfo")
user_interest_category = googleads_service.user_interest_path(
customer_id, user_interest
)
user_interests_info.user_interest_category = user_interest_category
attributes.user_interest = user_interests_infoJust do this:
attributes = client.get_type("AudienceInsightsAttribute")
attributes.user_interest.user_interest_category = googleads_service.user_interest_path(
customer_id, user_interest
)| insights_info.attributes.append(attributes) | ||
| request.audience.topic_audience_combinations.append(insights_info) | ||
|
|
||
| request.audience = client.get_type("InsightsAudience") |
BenRKarl
requested changes
Apr 30, 2025
| request.customer_insights_group = custom_name | ||
|
|
||
| audience_definition = client.get_type("InsightsAudienceDefinition") | ||
| audience = client.get_type("InsightsAudience") |
There was a problem hiding this comment.
Doesn't look like this is being used.
| request.customer_id = customer_id | ||
| request.customer_insights_group = custom_name | ||
|
|
||
| audience_definition = client.get_type("InsightsAudienceDefinition") |
There was a problem hiding this comment.
Change this line to:
audience_definition = request.audience_definition
| kg_dimension = client.enums.AudienceInsightsDimensionEnum.KNOWLEDGE_GRAPH | ||
| request.dimensions = [category_dimension, kg_dimension] | ||
| request.customer_insights_group = custom_name | ||
| response = audience_insights_service.list_audience_insights_attributes |
There was a problem hiding this comment.
You'll need to call the list_audience_insights_attributes method, like this:
list_audience_insights_attributes(request=request)There was a problem hiding this comment.
Typo!! Fixed
BenRKarl
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code snippets for Audience Insights APIs for Google Ads.