Add type hints to examples/shopping_ads #956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds type annotations to all Python files within the examples/shopping_ads directory. Type hints were added for function arguments, return values, class attributes, and local variables to improve code clarity, maintainability, and enable static analysis.
sundquist
requested changes
May 28, 2025
|
|
||
| print( | ||
| f"Created shopping product ad group ad '{ad_group_ad_resource_name}'." | ||
| ) | ||
|
|
||
| # Note: Original code returns ad_group_resource_name. |
There was a problem hiding this comment.
Perhaps this comment is no longer relevant after the changes since nothing changed. I suggest removing it.
| client, customer_id, campaign_resource_name | ||
| ) | ||
|
|
||
| # Create a shopping product ad group ad. | ||
| # Note: The function add_shopping_product_ad_group_ad currently returns |
Changed import paths from google.ads.googleads.v17 to google.ads.googleads.v20 and updated GoogleAdsClient.load_from_storage to use version='v20'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds type annotations to all Python files within the examples/shopping_ads directory.
Type hints were added for function arguments, return values, class attributes, and local variables to improve code clarity, maintainability, and enable static analysis.