Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

gbretas
Copy link
Contributor

@gbretas gbretas commented Nov 2, 2024

Related to issue #508 and #465.

@gbretas
Copy link
Contributor Author

gbretas commented Nov 2, 2024

This pull request includes a modification to the WaitForReport method in the googleads/ad_manager.py file to allow customization of the polling interval. The most important changes include adding a new parameter for the polling interval and updating the sleep function to use this new parameter.

Enhancements to WaitForReport method:

  • googleads/ad_manager.py: Added pollTimeSeconds parameter to the WaitForReport method to allow customization of the polling interval. Updated the docstring to reflect this change.
  • googleads/ad_manager.py: Updated the time.sleep call within the WaitForReport method to use the new pollTimeSeconds parameter instead of a hardcoded value.

@gbretas
Copy link
Contributor Author

gbretas commented Nov 2, 2024

Changed the variable at PR @christopherseeley.

@gbretas
Copy link
Contributor Author

gbretas commented Jan 17, 2025

Hey @christopherseeley some news?

gbretas and others added 3 commits January 23, 2025 11:11
@gbretas
Copy link
Contributor Author

gbretas commented Jan 23, 2025

Done.

@christopherseeley christopherseeley merged commit 19829b6 into googleads:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants