Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Nov 29, 2022

This was part of the previous PR #376 (comment)

@lqiu96
Copy link
Member Author

lqiu96 commented Nov 29, 2022

Should we set the CLIRR check be required?

@lqiu96 lqiu96 requested a review from blakeli0 November 29, 2022 15:36
@lqiu96 lqiu96 marked this pull request as ready for review November 29, 2022 15:36
@lqiu96 lqiu96 requested a review from a team as a code owner November 29, 2022 15:36
@blakeli0
Copy link
Contributor

Should we set the CLIRR check be required?

No, they should be optional. There are some classes with InternalApi which are OK to make breaking changes.

@lqiu96 lqiu96 merged commit fe1a7c5 into main Nov 29, 2022
@lqiu96 lqiu96 deleted the main-cleanup_ci_jobs branch November 29, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants