Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

chore: Add rest of gradle dependencies #389

Merged
merged 3 commits into from
Dec 1, 2022
Merged

chore: Add rest of gradle dependencies #389

merged 3 commits into from
Dec 1, 2022

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Nov 30, 2022

This is to match:

dependencies {

  annotationProcessor libraries.auto_value

  implementation( libraries.guava,
    libraries.jsr305,
    libraries.javax_annotations,
    libraries.auto_value_annotations)

  compileOnly libraries.error_prone_annotations

  testImplementation(libraries.junit,
    libraries.truth)
}

@lqiu96 lqiu96 requested a review from blakeli0 November 30, 2022 17:01
@lqiu96 lqiu96 requested a review from a team as a code owner November 30, 2022 17:01
@lqiu96
Copy link
Member Author

lqiu96 commented Nov 30, 2022 •
edited
Loading

Keeping JSR305 (not sure what this is used for or if still relevant) and ErrorProneAnnotations (We don't seem to be running error_prone?) dependencies in pom.xml as part of the migration.

I don't think it hurts to keep them in case they have a use case that I'm missing.

@lqiu96 lqiu96 merged commit d47908a into main Dec 1, 2022
@lqiu96 lqiu96 deleted the main-maven_dependencies branch December 1, 2022 15:47
@suztomo suztomo mentioned this pull request Apr 11, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@blakeli0 blakeli0 blakeli0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @blakeli0