Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@daniel-sanche
Copy link
Collaborator

  • I added tests to check for proper monitored resources on all GCP environments
  • This behaviour should be the same in all app engine environments, so I made a new CommonAppEngine class to hold this kind of test
  • I also refactored the common test base class to include trigger_and_retrieve(), since that seems like it will be useful for a lot of different tests
  • I made some other small tweaks to try to make things less flaky as I worked

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2021
@daniel-sanche
Copy link
Collaborator Author

reviewed as part of googleapis/python-logging#200

@daniel-sanche daniel-sanche merged commit 0e33111 into main Mar 5, 2021
@daniel-sanche daniel-sanche deleted the monitored_resources branch March 5, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant