fix: mark server_streaming method as async #1502
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in https://github.com/googleapis/python-bigtable/pull/702/files#diff-cefca7c885a9bf43a6cc4769c788d30041fcffc582df926b7240e03beea308ebR529
In
google/cloud/bigtable_v2/services/bigtable/async_client.py
file,mutate_rows
should become a coroutine.and the call to the rpc should be awaited.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1503 🦕