feat: add support for async rest streaming methods #2146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4920e9 to
f66182f
Compare
f66182f to
604a4bf
Compare
8baebaf to
9efcb8a
Compare
604a4bf to
9c161d5
Compare
Base automatically changed from
implement-generic-async-rest-method
to
async-rest-support-in-gapics
September 17, 2024 18:20
dcbae0c to
e28ea63
Compare
vchudnov-g
reviewed
Sep 20, 2024
| {# TODO(https://github.com/googleapis/gapic-generator-python/issues/2171): Update the return type for pager method. #} | ||
| ){% if not method.void %} -> {% if not method.server_streaming %}{{method.output.ident}}{% else %}None{% endif %}{% endif %}: | ||
| {# TODO(https://github.com/googleapis/gapic-generator-python/issues/2168): Implement server streaming method. #} | ||
| ){% if not method.void %} -> {% if not method.server_streaming %}{{method.output.ident}}{% else %}rest_streaming_async.AsyncResponseIterator{% endif %}{% endif %}: |
There was a problem hiding this comment.
Is this present in any of the golden files? A search in this PR for rest_streaming_async.AsyncResponse only yields results in these templates, and not the goldens. I want to see how the goldens changed.
There was a problem hiding this comment.
Changes can be seen here: #2188
| {% else %} | ||
| pb_resp = resp | ||
| {% endif %} | ||
| {% endif %}{# if method.output.ident.is_proto_plus_type #} |
There was a problem hiding this comment.
One question: we handle proto_plus explicitly in the non-streaming case here. But what about in streaming results? Looking at api-core's _rest_streaming_base.py:BaseResponseIterator.grab(), it's not obvious that we do. Do we? Should we? Is this question irrelevant?
There was a problem hiding this comment.
I've filed #2189 to Investigate this later.
e28ea63 to
232d255
Compare
parthea
approved these changes
Sep 20, 2024
parthea
reviewed
Sep 20, 2024
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest_asyncio.py.j2
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the call method for an asynchronous rest streaming method and updates the relevant unit tests to add coverage.
This PR should be reviewed and merged after: #2145
Fixes: #2168