fix(serializer): catch Throwable to handle PHP 7+ Errors#664
Merged
Conversation
Use Throwable since the error message is actually Error which shares the base Throwable class but is not an Exception in PHP 7+.
bshaffer
approved these changes
Apr 21, 2026
Contributor
bshaffer
left a comment
There was a problem hiding this comment.
Thank you for finding and fixing this issue!
Hectorhammett
approved these changes
Apr 28, 2026
Contributor
|
Good catch! Pun intended! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP7+ introduced the following hierarchy: https://www.php.net/manual/en/language.errors.php7.php
There's a base Throwable class which both Error and Exception derive from.
When using the protobuf.so C extension, it's possible that an error message such as "Class zetasql.ErrorMessageModeForPayload hasn't been added to descriptor pool" can manifest as a TypeError or Error which don't derive from Exception and thus cause a fatal instead of being caught.