Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

feat: make samples/update-branch-protection.js is a flexible CLI #303

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

bcoe
Copy link

@bcoe bcoe commented Jul 31, 2019

You can now use add [rule], remove [rule]` to configure branch protection.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
@bcoe bcoe requested review from JustinBeckwith and alexander-fenster and removed request for JustinBeckwith July 31, 2019 20:07
@JustinBeckwith
Copy link
Contributor

This LGTM, but I wonder out loud - should we have this as a real command instead of a sample? Like should I be able to do:

$ repo update-branch-protection add 'kokoro: node 12'

@bcoe
Copy link
Author

bcoe commented Jul 31, 2019

@JustinBeckwith seems reasonable, perhaps create a tracking issue? a few of the samples would make sense to promote.

@alexander-fenster
Copy link
Contributor

Yeah, when I wrote this sample, there was no such thing as CLI at all. :) It really needs to be in CLI.

@JustinBeckwith
Copy link
Contributor

Captured in #304 :)

@JustinBeckwith JustinBeckwith merged commit b23c2b7 into master Jul 31, 2019
@bcoe bcoe deleted the branch-protection-tool branch July 31, 2019 20:21
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   59.89%   59.89%           
=======================================
  Files           5        5           
  Lines         379      379           
  Branches       44       44           
=======================================
  Hits          227      227           
  Misses        137      137           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5083df6...b2b946a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants