-
Notifications
You must be signed in to change notification settings - Fork 39
feat!: rename regex match as --title option #388
Conversation
Local tested the commands |
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 38.74% 38.11% -0.64%
==========================================
Files 19 19
Lines 2653 2663 +10
Branches 123 113 -10
==========================================
- Hits 1028 1015 -13
- Misses 1625 1648 +23
Continue to review full report at Codecov.
|
This changes how we use the tool, and while I support the change (it makes parameter logic for |
@xiaozhenliu-gg5 is the motivation that it makes the parameter more explicit; does it still accept a regex? might be worth documenting that title can be a regex in README? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please wait for @bcoe and/or @JustinBeckwith
old usage:
repo tag [--branch branch] [--author author] regex label1 label2 ...
It might be a little bit confused for new users to understand regex (match title). And either
--branch
andregex
must present.Now we rename regex as a flag
--title
to better explain the function of regex. And if no--branch
or--title
is present, command line will throw warning as before to remind users set one of the options.New usage: