Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

feat!: rename regex match as --title option #388

Merged
merged 7 commits into from
Apr 2, 2020
Merged

Conversation

xiaozhenliu-gg5
Copy link
Contributor

old usage: repo tag [--branch branch] [--author author] regex label1 label2 ...
It might be a little bit confused for new users to understand regex (match title). And either--branch and regex must present.
Now we rename regex as a flag --title to better explain the function of regex. And if no --branch or --title is present, command line will throw warning as before to remind users set one of the options.

New usage:

     $ repo list [--branch branch] [--author author] [--title title]
     $ repo approve [--branch branch] [--author author] [--title title]
     $ repo update [--branch branch] [--author author] [--title title]
     $ repo merge [--branch branch] [--author author] [--title title]
     $ repo reject [--branch branch] [--author author] [--title title]
     $ repo rename [--branch branch] [--author author] [--title title] 'new PR title'
     $ repo tag [--branch branch] [--author author] [--title title] label1 label2 ...
     $ repo apply --branch branch --message message --comment comment [--reviewers username[,username...]] [--silent] 

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@xiaozhenliu-gg5
Copy link
Contributor Author

xiaozhenliu-gg5 commented Apr 1, 2020

Local tested the commands repo list repo rename repo approve & repo tag to work well with the new option --title

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #388 into master will decrease coverage by 0.63%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   38.74%   38.11%   -0.64%     
==========================================
  Files          19       19              
  Lines        2653     2663      +10     
  Branches      123      113      -10     
==========================================
- Hits         1028     1015      -13     
- Misses       1625     1648      +23
Impacted Files Coverage Δ
src/tag-prs.ts 0% <0%> (ø) ⬆️
src/lib/asyncPrIterator.ts 0% <0%> (ø) ⬆️
src/rename-prs.ts 0% <0%> (ø) ⬆️
src/cli.ts 0% <0%> (ø) ⬆️
src/lib/config.ts 95.52% <0%> (-2.99%) ⬇️
src/lib/github.ts 62.26% <0%> (-1.57%) ⬇️
src/lib/update-repo.ts 99.2% <0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55687c8...8b9e32d. Read the comment docs.

@alexander-fenster
Copy link
Contributor

This changes how we use the tool, and while I support the change (it makes parameter logic for repo tag and repo rename much better), let's ask if @bcoe and @JustinBeckwith don't mind changing this :)

@bcoe
Copy link

bcoe commented Apr 1, 2020

@xiaozhenliu-gg5 is the motivation that it makes the parameter more explicit; does it still accept a regex? might be worth documenting that title can be a regex in README?

Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for @bcoe and/or @JustinBeckwith

@xiaozhenliu-gg5 xiaozhenliu-gg5 merged commit 410f274 into master Apr 2, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 deleted the tag-command branch April 2, 2020 22:14
@release-please release-please bot mentioned this pull request Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants