fix!: ESM, drop API, drop Node 12 support #611
Conversation
| import {GitHubRepository, Issue} from './lib/github.js'; | ||
| import {processIssues} from './lib/asyncItemIterator.js'; |
There was a problem hiding this comment.
I'm not very knowledgeable in ESM/CJS stuff, but it seems weird to need the .js?
There was a problem hiding this comment.
Weird indeed, but it cannot resolve imports without it. https://nodejs.org/api/esm.html#esm_mandatory_file_extensions
TypeScript understands these imports during compilation and preserves them, so they turn out just fine in the build folder.
And something about updating in branches, which I don't even remember what it was doing. Technically, I could leave those APIs, but I need to remove their unit tests (since they use |
|
@sofisl @bcoe @chingor13 ping on this :) |
This package is quite unique compared to other things in
googleapisrepository. It's a tool and not a library, and it has some dependencies we don't normally mess with, such aschalk,ora, andmeow.Since most of the dependencies dropped Node 12 in their latest versions and became ESM friendly, I'm suggesting this refactor to make this tool ESM compatible. I used
ncu -uto bump all the dependencies to their latest versions, and make some code fixes to make it all work together.BREAKING CHANGE: originally this tool was created (by me!) as a library, providing some API, with an expectation that the users will actually write the code to maintain GitHub repositories. It's not the case anymore, it was converted to a CLI tool long ago, and the main use case now is just use the
repoCLI. I'm dropping parts of the API previously exported and the samples showing how to use it, because I don't want to keep that bad code (also, because its tests usedproxyquire, which does not play well with ESM).BREAKING CHANGE: drop Node 12 support.
Other than that, everything should just work!