Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

feat: make possible to read custom baseUrl from config.yaml #631

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

pauloaraga0
Copy link
Contributor

  • add baseUrl to Config interface
  • set baseUrl from config if baseUrl is present in the config.yaml file
  • update README config.yaml example with baseUrl

Fixes #630 πŸ¦•

@pauloaraga0 pauloaraga0 requested a review from a team as a code owner March 26, 2023 13:47
@google-cla
Copy link

google-cla bot commented Mar 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 26, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@chingor13 chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2023
@chingor13 chingor13 merged commit 9862fe5 into googleapis:main Mar 29, 2023
@pauloaraga0
Copy link
Contributor Author

Thanks for this.

Thanks for the quick approval 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use GitHub custom baseUrl
3 participants