Making http parameter in discovery.build_from_document optional. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about test coverage? (This is my standard response to any contribution without test coverage, no matter how small a change.) |
discovery.build()'s http parameter is optional, but if you call build_from_document directly it doesn't handle the case where http is None. Fixed that so now you can call ``discovery.build_from_document(doc, credentials=credentials)``.
|
Tests added for the case where you do provide http and where you don't provide http, covering all branches there. |
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Jul 17, 2015
Making http parameter in discovery.build_from_document optional.
|
Thanks for the contribution! |
akrherz
pushed a commit
to akrherz/google-api-python-client
that referenced
this pull request
Apr 1, 2019
This avoids the potential issue of urllib detecting a proxy and changing the actual request underneath our code. The basic httplib library does not have any proxy detection, so this is not even possible there. Fixes googleapis#114.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovery.build()'s http parameter is optional, but if you call build_from_document directly it doesn't handle the case where http is None. Fixed that so now you can call
discovery.build_from_document(doc, credentials=credentials).