return if the batch is empty #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
This looks alright, but what use case is this supporting? How did this situation arise for you? |
|
We loop through a list of users and batch add them to a group. The users to add have to respect a certain criteria, and we expected that if none of them was to be added, to have nothing happen. |
|
Okay. Thanks for the contribution! |
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Jul 30, 2015
Return if the batch is empty in BatchHttpRequest.execute.
akrherz
pushed a commit
to akrherz/google-api-python-client
that referenced
this pull request
Apr 1, 2019
Update type on run_flow() to be accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batch execute when not given an http object will look into the given requests. If no request was given, it will raise a
ValueError("Missing a valid http object.").