Force HttpMock to read content from file as bytes #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLA has now been signed. |
|
CLAs look good, thanks! |
|
A one-byte fix? Are we sure there's not something less drastic we could do instead? :-P |
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Aug 13, 2015
Force HttpMock to read content from file as bytes.
|
Thanks for the contribution! |
alanbriolat
added a commit
to alanbriolat/csbot
that referenced
this pull request
Aug 14, 2015
Test cases will only apply when a new version of google-api-python-client is released, because of a bug in the apiclient.http.HttpMock class (see googleapis/google-api-python-client#125). fixes HackSoc#103 (and HackSoc#99)
alanbriolat
added a commit
to alanbriolat/csbot
that referenced
this pull request
Aug 14, 2015
Test cases will only apply when a new version of google-api-python-client is released, because of a bug in the apiclient.http.HttpMock class (see googleapis/google-api-python-client#125). fixes HackSoc#103 (and HackSoc#99)
akrherz
pushed a commit
to akrherz/google-api-python-client
that referenced
this pull request
Apr 1, 2019
Fixes googleapis#125. NOTE: '%s.%s' does not behave the same between versions and should be removed throughout this library. I will be following this up with a set of regression tests (hopefully some of which will fail) and we can assess the damage of other uses of '%s'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124.
I decided to write the test for the functionality I was actually trying to use, and which was previously not covered by tests: using
HttpMockspecifically to mock error responses. The side effect is that it exposes howHttpMockwas not not reading content as bytes on Python 3 and causing a confusing exception to be thrown.I think the fix speaks for itself...