Replace uses of as_string from the email lib.
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
The `as_string` function from `email.message.Message` assumes that it's being used to encode a message for, well, email transmission -- and as a result, it changes lines beginning with "From " into lines beginning with ">From ". Given that we're using that module for multipart uploads, this behavior is surely not what we want. We basically inline the body of `as_string`, setting `mangle_from_` to `False`.
craigcitro
added a commit
that referenced
this pull request
Jul 16, 2014
Replace uses of `as_string` from the email lib.
akrherz
pushed a commit
to akrherz/google-api-python-client
that referenced
this pull request
Apr 1, 2019
Support the login_hint parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as_stringfunction from theemailmodule assumes that it's being usedto encode a message for, well, email transmission -- and as a result, it
changes lines beginning with "From " into lines beginning with ">From ". Given
that we're using this for multipart uploads, this is surely not what we want.
We basically inline the body of
as_string, settingmangle_from_toFalse.PTAL @skelterjohn