Specify allowed version range for dependencies #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the build is frozen. |
|
Okay, punting on this until after #182 is integrated. |
|
+1 |
|
Change content looks good, but please edit your commit message to conform to these guidelines. Also drop the reference to #179 now that it has been addressed. |
Prevent breaking changes when one of dependencies updates its major version.
|
Updated. |
|
Looks good; will merge after tests re-pass. |
|
+1 on this. Can someone push out a new version once this is in place as well please, this has broken a few things for us. |
|
+1 |
|
Merged as 54b203a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent breaking changes when one of dependencies is updated with major changes.
This depends on google/google-api-python-client/#182 where oauth2client 2.0 issues are fixed.