App default creds #351
App default creds #351
Conversation
62f4071 to
2b98e61
Compare
This should address googleapis#350.
| @@ -1202,7 +1202,17 @@ def _serialize_request(self, request): | |||
|
|
|||
| if request.http is not None and hasattr(request.http.request, | |||
| 'credentials'): | |||
| request.http.request.credentials.apply(headers) | |||
| credentials = request.http.request.credentials | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@mgilson thanks for doing this- heads up I'm pretty busy the next couple of days but I will try to get to this by friday. |
|
Thanks for letting me know when to be looking into this again. I'm in no hurry -- We've already coded the workaround that I mentioned in the issue on our end so there's nothing mission critical for us. In other words, take your time. :-) |
|
@mgilson sorry I got super backlogged on this. I think it might not be as easy as we think - this library has to support both oauth2client and google-auth. We might have to add some special logic to handle those. Let me find some time to look into this in more depth to see what's up. |
|
Closing in favor of #376. |
re-fixes googleapis#350. it was originally fixed by c669a3b following discussion in googleapis#351 (comment) , but then that fix got lost in the next commit, googleapis@282fc88 .
re-fixes googleapis#350. it was originally fixed by c669a3b following discussion in googleapis#351 (comment) , but then that fix got lost in the next commit, googleapis@282fc88 .
re-fixes googleapis#350. it was originally fixed by c669a3b following discussion in googleapis#351 (comment) , but then that fix got lost in the next commit, googleapis@282fc88 .
Only authenticate individual requests in a batch if the credentials are non-
None. Otherwise, assume that an appropriate authentication is being provided at a higher level (e.g. for the entire batch)This should address #350