Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HttpRequest.__init__ remove useless mimeparse #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2018
Merged

HttpRequest.__init__ remove useless mimeparse #467

merged 1 commit into from
Jan 19, 2018

Conversation

xmedeko
Copy link
Contributor

@xmedeko xmedeko commented Jan 17, 2018

Fix #284

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2018
@theacodes
Copy link
Contributor

@xmedeko this might be useful, can you add a test that demonstrates the case?

@xmedeko
Copy link
Contributor Author

xmedeko commented Jan 17, 2018

A test code is in the #284. Do you mean a test into the test_http.py?

@theacodes
Copy link
Contributor

theacodes commented Jan 17, 2018 via email

@xmedeko
Copy link
Contributor Author

xmedeko commented Jan 19, 2018

Added a simple test of HttpRequest.__init__ by amend.
Note: the mimeparse.parse_mime_type is not used and may be removed?
Note2: http.py has some unused imports: base64, gzip, sys

@theacodes theacodes merged commit b86bfc9 into googleapis:master Jan 19, 2018
@theacodes
Copy link
Contributor

Thanks, @xmedeko

@xmedeko xmedeko deleted the http_init branch January 19, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmedeko @theacodes @googlebot