Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop oauth2client dependency #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2018
Merged

Conversation

helen-fornazier
Copy link
Contributor

oauth2client is deprecated, use google-auth instead
Closes #437

Helen Koike added 4 commits April 27, 2018 13:34
Executing tox in the project directory is not the same of what is being
executed in travis-ci
This cause problems when replacing oauth2client library by google-auth
in the setup.py because oauth2client is mandatory for tests, and travis
was not installing oauth2client if it is not in the setup.py.
Also it is good to keep the consistency of the test environments.
Fix import error message for file_cache
The import can failed not only because we are using oauth2client>4.0.0
but also when we are using google-auth
Use local googleapiclient _helpers
oauth2client is deprecated, use google-auth instead
Closes googleapis#437
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2018
@helen-fornazier helen-fornazier changed the title No oauth Drop oauth2client dependency Apr 27, 2018
@theacodes theacodes self-requested a review April 27, 2018 17:08
@theacodes theacodes changed the title Drop oauth2client dependency [MERGE AFTER NEXT RELEASE] Drop oauth2client dependency Apr 27, 2018
@theacodes theacodes changed the title [MERGE AFTER NEXT RELEASE] Drop oauth2client dependency Drop oauth2client dependency May 31, 2018
@theacodes theacodes merged commit 9eb303e into googleapis:master May 31, 2018
@helen-fornazier helen-fornazier deleted the no-oauth branch May 31, 2018 23:20
@amureki
Copy link

amureki commented Jun 1, 2018

Thank you, everyone, for finalizing this! ✨ ✨ ✨

adjackura pushed a commit to GoogleCloudPlatform/compute-image-tools that referenced this pull request Jun 5, 2018
dotlambda added a commit to dotlambda/nixpkgs that referenced this pull request Mar 25, 2025
dotlambda added a commit to dotlambda/nixpkgs that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants